From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has posted comments on this change.
Change subject: rpmlint: ignore only limited set of errors ...................................................................... Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/69444/4//COMMIT_MSG Commit Message: Line 16: Line 17: We should explicitly list the failing tests, to make sure that no new Line 18: failure is added. Line 19: Line 20: Reviewed-on: https://gerrit.ovirt.org/#/q/I1a6e21b61b9b31a07d7cd3af2ed9ab8506c46c5a fix link to https://gerrit.ovirt.org/#/c/69444/ Line 21: Change-Id: I1a6e21b61b9b31a07d7cd3af2ed9ab8506c46c5a https://gerrit.ovirt.org/#/c/69444/4/automation/check-patch.sh File automation/check-patch.sh: Line 28: if git diff-tree --no-commit-id --name-only -r HEAD | egrep --quiet 'vdsm.spec.in|Makefile.am' ; then Line 29: ./automation/build-artifacts.sh Line 30: yum -y install "$EXPORT_DIR/"!(*.src).rpm Line 31: export LC_ALL=C # no idea why this is suddenly needed Line 32: rpmlint "$EXPORT_DIR/"*.src.rpm I think better to add the commit msg comment to the code itself as well - "this is to ignore known issues and scream when new issue appears" Line 33: ! rpmlint "$EXPORT_DIR/"!(*.src).rpm | grep ': E: ' | grep -v explicit-lib-dependency | \ Line 34: grep -v no-binary | grep -v zero-length | \ Line 35: grep -v non-readable | grep -v non-standard-dir-perm -- To view, visit https://gerrit.ovirt.org/69444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a6e21b61b9b31a07d7cd3af2ed9ab8506c46c5a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
