From Yaniv Bronhaim <ybron...@redhat.com>: Yaniv Bronhaim has posted comments on this change.
Change subject: rpmlint: ignore only limited set of errors ...................................................................... Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/69444/4//COMMIT_MSG Commit Message: Line 11: explicit-lib-dependency Line 12: no-binary Line 13: zero-length Line 14: non-readable Line 15: non-standard-dir-perm maybe write few words about why we accept the fail? .. if we have a reason Line 16: Line 17: We should explicitly list the failing tests, to make sure that no new Line 18: failure is added. Line 19: -- To view, visit https://gerrit.ovirt.org/69444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a6e21b61b9b31a07d7cd3af2ed9ab8506c46c5a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Irit Goihman <igoih...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
