From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: net test: Cleanup colliding test ip rules ...................................................................... Patch Set 3: Code-Review+1 (1 comment) https://gerrit.ovirt.org/#/c/76781/3/tests/network/ip_rule_test.py File tests/network/ip_rule_test.py: Line 70: rules = [r for r in IPRule.rules() if r.to == IPV4_ADDRESS1] Line 71: for rule in rules: Line 72: print('Detected colliding test ip rule, deleting:', str(rule), Line 73: file=sys.stderr) Line 74: IPRule.delete(rule) > We read the kernel config and remove the entries immediately, unless someon I actually prefer not to handle double errors. If we fails to delete an existing rule there's something even more fishy in the system; and the future test would fail anyway. There's no much point in attempting to do anything else. But then again, I won't fight over it, either. -- To view, visit https://gerrit.ovirt.org/76781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I461ad5697525cfaa2e3c6cfa66269692283903ce Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Edward Haas <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
