From Dan Kenigsberg <dan...@redhat.com>: Dan Kenigsberg has posted comments on this change.
Change subject: net test: Cleanup colliding test ip rules ...................................................................... Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/76781/7/tests/network/__init__.py File tests/network/__init__.py: Line 28: from . ip_rule_test import IPV4_ADDRESS1 Line 29: Line 30: Line 31: def teardown_package(): Line 32: if six.PY2: > ip.rule is not py3 compatible, its tests are in the black list. (The build Could you explain this in a comment? Otherwise we'd forget to drop this when ip.rule is made compatible with py3. Line 33: _cleanup_stale_iprules() Line 34: Line 35: Line 36: class StaleIPRulesError(Exception): -- To view, visit https://gerrit.ovirt.org/76781 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I461ad5697525cfaa2e3c6cfa66269692283903ce Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Edward Haas <edwa...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org
