From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: ssl: enable tlsv1.2 support ...................................................................... Patch Set 30: (1 comment) https://gerrit.ovirt.org/#/c/72284/30/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py: Line 272: protocols = [] Line 273: Line 274: for no_protocol in config.get('vars', 'ssl_protocol').split(','): Line 275: if no_protocol != '': Line 276: protocols.append(getattr(ssl, no_protocol.strip())) > Correct, now we have protocol and excludes. Internally, I don't think that we really need protocol - we should always use PROTOCOL_TLS, and always pepper options on top of it. this function should translate whatever a user requested hitorically into the OP_NO_* integer which we should be using to give them what they wanted. Line 277: -- To view, visit https://gerrit.ovirt.org/72284 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cc83d8cc08349a0ca47ed7d021bb3fc6d1408a6 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
