From Dan Kenigsberg <[email protected]>: Dan Kenigsberg has posted comments on this change.
Change subject: ssl: enable tlsv1.2 support ...................................................................... Patch Set 31: (1 comment) https://gerrit.ovirt.org/#/c/72284/31/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py: Line 271: Line 272: def protocol_name_to_int(): Line 273: excludes = 0 Line 274: Line 275: for no_protocol in config.get('vars', 'ssl_protocol').split(','): I still do not get why you ignore someone who has set ssl_protocol to something like "sslv23" or another formerly-allowed value. Line 276: if no_protocol != '': Line 277: excludes |= getattr(ssl, no_protocol.strip()) Line 278: -- To view, visit https://gerrit.ovirt.org/72284 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8cc83d8cc08349a0ca47ed7d021bb3fc6d1408a6 Gerrit-PatchSet: 31 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Irit Goihman <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: gerrit-hooks <[email protected]> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list -- [email protected] To unsubscribe send an email to [email protected]
