Antoni Segura Puimedon has posted comments on this change. Change subject: [WIP] hooks: Add Quantum vNIC hook ......................................................................
Patch Set 2: (1 inline comment) .................................................... File vdsm_hooks/quantumvnic/before_vm_start.py Line 7: Line 8: from xml.dom import minidom Line 9: Line 10: QVNIC_PREFIX = 'quantumvnic_' Line 11: DUMMY_BRIDGE = ';vdsmdummy;' DUMMY_BRIDGE is defined in lib/vdsm/netinfo which is located on /usr/lib64/python2.x/site-packages/ and thus available when running hooks. I'd just put from netinfo import DUMMY_BRIDGE Line 12: DEV_MAX_LENGTH = 15 Line 13: Line 14: ''' Line 15: Openstack Quantum Hook -- To view, visit http://gerrit.ovirt.org/11108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I744b83d9c6027bd817e5d4171a77a005611b9818 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Mike Kolesnik <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
