Dan Kenigsberg has posted comments on this change.
Change subject: [WIP] hooks: Add Quantum vNIC hook
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm_hooks/quantumvnic/before_vm_start.py
Line 82:
Line 83: if __name__ == '__main__':
Line 84: try:
Line 85: main()
Line 86: # test()
well, it could be even prettier to add a command-line such as --test in order
to run the test() function instead of main(). Not that it's of high urgency.
Line 87: except:
Line 88: hooking.exit_hook('quantumvnic hook: [unexpected error]: %s\n'
%
--
To view, visit http://gerrit.ovirt.org/11108
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I744b83d9c6027bd817e5d4171a77a005611b9818
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
