Giuseppe Vallarelli has posted comments on this change.
Change subject: net_functional_tests: bondWithManyVlans.
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File tests/functional/networkTests.py
Line 58:
Line 59: with self.vdsm_net.pinger():
Line 60: status, msg = self.vdsm_net.setupNetworks(networks,
bondings,
Line 61: {})
Line 62: net_info = self.vdsm_net.getNetInfo()
This is not blackbox testing anymore, I do not expect to see any net_info in
the test
that is part of the inner workings of vdsm...
Line 63: self.assertEqual(status, SUCCESS, msg)
Line 64: for vlan_net in network_names:
Line 65: self.assertTrue(self.vdsm_net.networkExists(vlan_net,
bridged,
Line 66: net_info))
....................................................
File tests/functional/utils.py
Line 170: if info is None:
Line 171: info =
netinfo.NetInfo(self.vdscli.getVdsCapabilities()['info'])
Line 172: return vlan_name in info.vlans
Line 173:
Line 174: def getNetInfo(self):
Hide this function it's an implementation detail.
Line 175: return
netinfo.NetInfo(self.vdscli.getVdsCapabilities()['info'])
Line 176:
Line 177: @contextmanager
Line 178: def pinger(self):
--
To view, visit http://gerrit.ovirt.org/16025
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9da7bd407cfbd9acab5e20384bff1254c26ffc5
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
