Giuseppe Vallarelli has posted comments on this change.
Change subject: net_functional_tests: bondWithManyVlans.
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File tests/functional/networkTests.py
Line 57: bondings = {BONDING_NAME: {'nics': nics}}
Line 58:
Line 59: with self.vdsm_net.pinger():
Line 60: status, msg = self.vdsm_net.setupNetworks(networks,
bondings,
Line 61: {})
All right, but the first sentence of Zen of Python says: "Beautiful is better
than ugly" ;-) . VdsProxy is there to prevent to write code which is useless
for the matter of test, in this case options is undefined or if you prefer
defined with no options in it.
Line 62: self.assertEqual(status, SUCCESS, msg)
Line 63: for vlan_net in network_names:
Line 64: self.assertTrue(self.vdsm_net.networkExists(vlan_net,
bridged))
Line 65: self.assertTrue(self.vdsm_net.bondExists(BONDING_NAME,
nics))
--
To view, visit http://gerrit.ovirt.org/16025
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9da7bd407cfbd9acab5e20384bff1254c26ffc5
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
