Martin Sivák has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/hooks.py
Line 59: os.write(xmlfd, domxml or '')
Line 60: os.close(xmlfd)
Line 61:
Line 62: scriptenv = os.environ.copy()
Line 63: scriptenv.update(vmconf.get('custom', {}))
Well no LC_ALL=C means everything you are getting is encoded in ASCII.
Even if I use the loop only for the custom properties I still need to know the
encoding of the data. Otherwise I am trying to decode something I know nothing
about and hope it will work.
Line 64: if len(params) > 0:
Line 65: scriptenv.update(params)
Line 66: if vmconf.get('vmId'):
Line 67: scriptenv['vmId'] = vmconf.get('vmId')
--
To view, visit http://gerrit.ovirt.org/15856
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9063291f8a4a392b2913220fe2839386dcffd825
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: David Caro <[email protected]>
Gerrit-Reviewer: Martin Sivák <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
