Arik Hadas has uploaded a new change for review. Change subject: do not rely on default values on restoreFlags invocation ......................................................................
do not rely on default values on restoreFlags invocation The signature of libvirt's verb 'restoreFlags' changed - in previous versions it didn't set default values for its optional arguments. this patch changes how we invoke this verb to set the 'flags' argument to 0 explicitly in order to be backward compatible with libvirt versions that don't set default values for 'restoreFlags' arguments. Change-Id: I0dd348370c5dd6adfad813c7f01904c170f523bf Bug-Url: https://bugzilla.redhat.com/988229 Signed-off-by: Arik Hadas <aha...@redhat.com> --- M vdsm/vm.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/17298/1 diff --git a/vdsm/vm.py b/vdsm/vm.py index 0da06a9..cd37ae3 100644 --- a/vdsm/vm.py +++ b/vdsm/vm.py @@ -2882,7 +2882,7 @@ fname = self.cif.prepareVolumePath(self.conf['restoreState']) try: if fromSnapshot: - self._connection.restoreFlags(fname, srcDomXML) + self._connection.restoreFlags(fname, srcDomXML, 0) else: self._connection.restore(fname) finally: -- To view, visit http://gerrit.ovirt.org/17298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0dd348370c5dd6adfad813c7f01904c170f523bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
