Dan Kenigsberg has posted comments on this change. Change subject: do not rely on default values on restoreFlags invocation ......................................................................
Patch Set 1: Looks good to me, approved Since passing the argument explicitly has not been deprecated, and since this fix is actually simpler than requiring a newer libvirt version, and since Michal does not nack it, I think we're good to take it in. -- To view, visit http://gerrit.ovirt.org/17298 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dd348370c5dd6adfad813c7f01904c170f523bf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Yeela Kaplan <ykap...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
