Dan Kenigsberg has posted comments on this change.
Change subject: Management network is now kept in main routing table
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 182: for nic in nics:
Line 183: _validateInterNetworkCompatibility(_netinfo, vlan,
nic,
Line 184: bridged)
Line 185:
Line 186: options['DEFROUTE'] = \
Please note my comment on the previous patch.
Line 187: 'yes' if network == constants.MANAGEMENT_DEVICE else 'no'
Line 188:
Line 189: logging.info("Adding network %s with vlan=%s, bonding=%s,
nics=%s,"
Line 190: " bondingOptions=%s, mtu=%s, bridged=%s, options=%s",
--
To view, visit http://gerrit.ovirt.org/17575
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55c50269dd3d52fd058951200282c925a7014aca
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
