Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
......................................................................
Patch Set 18:
(1 comment)
....................................................
File vdsm/vdsmd.init.in
Line 83: fi
Line 84:
Line 85: "${VDSMD_INIT_COMMON}" --shutdown-conflicting-srv
"${CONFLICTING_SERVICES}"
Line 86:
Line 87: "${VDSMD_INIT_COMMON}" --start-needed-srv "${NEEDED_SERVICES}"
You are suggesting using downstream specific commands to start the
dependencies. I think it's OK but we need to address which downstream distro we
are writing this file for. I'd like to make this explicit in the name of
vdsmd.init.in. And I provide some thoughts that a single Upstart or SysV init.d
script can not suit all the downstream distros. So finally we may have
init/sysv/debian-vdsmd.init.in
init/sysv/rhel-vdsmd.init.in # for both Fedora and RHEL
init/upstart/ubuntu-vdsmd.upstart.in
init/systemd/rhel-vdsmd.service # for both Fedora and RHEL
if we do not address the downstream distro explicitly in this vdsmd.init.in,
we'd like continue to use "vdsm_init_common.sh --start-needed-srv", a general
one.
I also want to suggest we maintain the distro specific things in the VDSM
community, because Ubuntu developers may be not interested in this. We want to
take the first step and do our best to maintain VDSM on each platform then
attract those downstream developers. So suppose VDSM developers maintain RHEL
SysV init script, a Debian SysV init script, and a Ubuntu Upstart script, in
the upstream. All three need to start dependency services. Wouldn't be nice if
we can use the following.
RHEL SysV
vdsm_init_common.sh --start-needed-srv "multipathd iscsid libvirtd
supervdsmd..."
Debian SysV
vdsm_init_common.sh --start-needed-srv "multipath-tools open-iscsi libvirt-bin
supervdsmd..."
Ubuntu Upstart
vdsm_init_common.sh --start-needed-srv "multipath-tools open-iscsi libvirt-bin
supervdsmd..."
I think it's cleaner. We do not have to re-implement and maintain different
versions start-needed-srv in each script. Just one "vdsm_init_common.sh
--start-needed-srv" to rule them all.
If you think having this short notation is conflicting with the purpose of
making each distro specific file more distro dependent and hiding VDSM
internals, I'm willing to take your advice. I think this is a tade-off, between
re-using general and clean code but need to understand it, and re-implementing
specific ones but familiar to people in respective communities.
Line 88:
Line 89: "${VDSMD_INIT_COMMON}" --pre-start
Line 90:
Line 91: echo $"Starting up vdsm daemon: "
--
To view, visit http://gerrit.ovirt.org/15578
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Mei Liu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
