Alon Bar-Lev has posted comments on this change. Change subject: vdsmd and supervdsmd: extract common init tasks and add init adapter ......................................................................
Patch Set 19: (1 comment) .................................................... File vdsm/systemd-vdsmd.in Line 23: exit 1 Line 24: fi Line 25: Line 26: shift Line 27: "@LIBEXECDIR@/vdsmd_init_common.sh" --reconfigure "$@" > If we do not need reconfigure_sanlock to appear in two places, why we need > libvirt configuration in two places? Because the common initd script should be legacy free. The libvirt configuration is done by vdsm tool, a simple command... this is the one place. Calling the common to call vdsm-tool only makes it even more complex regardless of the legacy argument. At the prestart you need only to call libvirt configure without force, removing the conditional. Here you should call the libvirt configure with or without force based on the $2. -- To view, visit http://gerrit.ovirt.org/15578 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Mei Liu <[email protected]> Gerrit-Reviewer: Saggi Mizrahi <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
