Zhou Zheng Sheng has posted comments on this change.
Change subject: vdsmd and supervdsmd: extract common init tasks and add init
adapter
......................................................................
Patch Set 19:
(1 comment)
....................................................
File vdsm/systemd-vdsmd.in
Line 23: exit 1
Line 24: fi
Line 25:
Line 26: shift
Line 27: "@LIBEXECDIR@/vdsmd_init_common.sh" --reconfigure "$@"
OK. So this script should be like
if [ "$1" != "reconfigure" ]; then
echo "Usage: ..." >&2
exit 1
fi
if [ "$2" = "force" ]; then
vdsm-tool libvirt-configure --force
else
vdsm-tool libvirt-configure
fi
and in this patch should rebase on yours for removing reconfigure_sanlock, then
in vdsmd_init_common we remove the "--reconfigure" option, just call vdsm-tool
without force in prestart task.
Right?
--
To view, visit http://gerrit.ovirt.org/15578
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id8e514df1ca88500f746242134ddb24c31588046
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Mei Liu <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
