Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
......................................................................
Patch Set 3:
(1 comment)
....................................................
File debian/patches/libvirt-conf-path.patch
Line 15: set_if_default "${ldconf}" DAEMON_COREFILE_LIMIT unlimited
Line 16: set_if_default "${qconf}" save_image_format \"lzop\"
Line 17: + set_if_default "${qconf}" user \"@QEMUUSER@\"
Line 18: + set_if_default "${qconf}" group \"@QEMUGROUP@\"
Line 19: + echo unix_sock_group=\"@VDSMGROUP@\" >> "${lconf}"
In Fedora, libvirtd.conf the unix_sock_group is not set, but in Ubuntu, it is
set as
unix_sock_group = "libvirtd"
I find another way for solving the unix_sock_group problem. I add vdsm user to
libvirtd group in the post install script. So this line can be deleted from the
patch.
As regarded to set the qemu process user and group, at first I wrote the patch
for Debian "sid"'s libvirt, but I found there are conflicts, so I drop to
Ubuntu's libvirt. These two lines are not needed in Ubuntu, so in the next
patch set, this .patch file will be dropped.
Line 20: # FIXME until we are confident with libvirt integration, let us
have a verbose log
Line 21: set_if_default "${lconf}" log_outputs
\"1:file:/var/log/libvirt/libvirtd.log\"
--
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
