Zhou Zheng Sheng has posted comments on this change.
Change subject: Packaging: VDSM v4.12.0 packaged on Ubuntu
......................................................................
Patch Set 4:
(2 comments)
....................................................
File debian/patches/fix-util-path.patch
Line 5:
Line 6: # External programs (sorted, please keep in order)
Line 7: AC_PATH_PROG([BLKID_PATH], [blkid], [/sbin/blkid])
Line 8: -AC_PATH_PROG([BRCTL_PATH], [brctl], [/usr/sbin/brctl])
Line 9: +AC_PATH_PROG([BRCTL_PATH], [brctl], [/sbin/brctl])
This is because bridge-utils is not in the build dependency. So on a clean
build machine, after install all build dependencies, brctl is still missing,
and AC_PATH_PROG uses the default value. This is not an error though.
Line 10: AC_PATH_PROG([CAT_PATH], [cat], [/bin/cat])
Line 11: AC_PATH_PROG([CHKCONFIG_PATH], [chkconfig], [/sbin/chkconfig])
Line 12: AC_PATH_PROG([CHMOD_PATH], [chmod], [/bin/chmod])
Line 13: @@ -167,15 +167,15 @@
....................................................
File debian/patches/libvirt-conf-path.patch
Line 5: QEMU_DUMP_PATH="/var/log/core"
Line 6: LCONF="@sysconfdir@/libvirt/libvirtd.conf"
Line 7: QCONF="@sysconfdir@/libvirt/qemu.conf"
Line 8: -LDCONF="@sysconfdir@/sysconfig/libvirtd"
Line 9: +LDCONF="@sysconfdir@/default/libvirt-bin"
I also think it's good to have "--with-libvirtd-service=libvirt-bin". For the
same reason we may also have "--with-iscsd-service=" and
"--with-multipathd-service=". Since only "--with-libvirtd-service=" is
necessary for Ubuntu packaging, if I am to submit a patch, I'd add
"--with-libvirtd-service=" only, other service name options can be skipped.
Agree?
Line 10: QLCONF="@sysconfdir@/libvirt/qemu-sanlock.conf"
Line 11: [ "${LIBVIRT_SANLOCK}" = "false" ] && QLCONF="/dev/null"
--
To view, visit http://gerrit.ovirt.org/18443
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab62aeadfa65baef3f0f4e6da2592fa0ff451c6f
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
