Zhou Zheng Sheng has posted comments on this change.

Change subject: virtTests: fix initramfs permission detection
......................................................................


Patch Set 1:

(1 comment)

....................................................
File tests/functional/virtTests.py
Line 68: def _detectBootImages(initramfsPaths):
Line 69:     if not os.path.isfile(_kernelPath):
Line 70:         raise SkipTest("Can not locate kernel image for release %s" %
Line 71:                        _kernelVer)
Line 72:     if not os.access(_kernelPath, os.R_OK):
Does kernel image permission detection needs os.stat and S_IROTH too?
Line 73:         raise SkipTest("qemu process can not read the file "
Line 74:                        "%s" % _kernelPath)
Line 75: 
Line 76:     initramfsPaths = filter(os.path.isfile, initramfsPaths)


-- 
To view, visit http://gerrit.ovirt.org/20031
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I64316c727af529fd921553e2d8363b3946ad398d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpole...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Martin Polednik <mpole...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to