Dan Kenigsberg has posted comments on this change. Change subject: virtTests: fix initramfs permission detection ......................................................................
Patch Set 2: Code-Review+2 (1 comment) .................................................... Commit Message Line 13: as os.access would see it as readable while it in fact was not. Line 14: Line 15: This patch replaces os.access call with os.stat call, Line 16: which checks for permissions of >004 to make sure that Line 17: vdsm user can or can't read initramfs Actually, a more exact solution to this is with something like supervdsm.validateAccess(). But the latter requires root, so let us wait with it. Line 18: Line 19: Change-Id: I64316c727af529fd921553e2d8363b3946ad398d -- To view, visit http://gerrit.ovirt.org/20031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64316c727af529fd921553e2d8363b3946ad398d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpole...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Zhou Zheng Sheng <zhshz...@linux.vnet.ibm.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
