Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
......................................................................
Patch Set 16:
(3 comments)
....................................................
Commit Message
Line 6:
Line 7: Unified network persistence [4.2/4.*] - Upgrade updates running conf
Line 8:
Line 9: Run a VDSM upgrade that gathers net info and updates the running
Line 10: config of the unified network persistence.
you can just say:
This patch adds pre-start task that runs vdsm-tool upgrade which does blah blah
more clear imo..
Line 11:
Line 12: Ran using vdsm-tool upgrade mechanism as part of pre-start functions
Line 13: in init/vdsmd_init_common.sh.in
Line 14:
....................................................
File lib/vdsm/tool/unified_persistence.py
Line 29: networks, bondings = self._getNetInfo()
Line 30: self._persist(networks, bondings)
Line 31:
Line 32: def isNeeded(self):
Line 33: return config.get('vars', 'persistence') == 'unified'
I prefer:
return True if config.get('vars', 'persistence') == 'unified' else False
Line 34:
Line 35: def _toIfcfgFormat(self, value):
Line 36: filter = {'on': 'yes', 'off': 'no'}
Line 37: # If value is in the dict and hashable - Get its filtered
value.
Line 129: def unified_persistence():
Line 130: """
Line 131: Upgrade host networking persistence from ifcfg to unified if the
Line 132: persistence model is set as unified in
/usr/lib64/python2.X/site-packages/
Line 133: vdsm/config.py
way too long. this info is provided as help string on the command.. can't you
find something more sufficient and short ?
Line 134: """
Line 135: unifiedPersistenceUpgrade = UnifiedPersistence()
Line 136: upgradeName = UnifiedPersistence.__name__
Line 137: upgrade = Upgrade(upgradeName)
--
To view, visit http://gerrit.ovirt.org/18425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Assaf Muller <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Giuseppe Vallarelli <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
