Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.2/4.*] - Upgrade updates running
conf
......................................................................
Patch Set 18: Code-Review-1
(1 comment)
one last comment
....................................................
File lib/vdsm/tool/unified_persistence.py
Line 138:
Line 139: if upgrade.isNeeded() and unifiedPersistenceUpgrade.isNeeded():
Line 140: upgrade.log.debug("Running upgrade %s" % upgradeName)
Line 141: unifiedPersistenceUpgrade.run()
Line 142: upgrade.seal()
as a command you should return 0 on success or always, raise exception on
failure
--
To view, visit http://gerrit.ovirt.org/18425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I051b0f168b6357e60184409845ea410c5891b083
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com>
Gerrit-Reviewer: Assaf Muller <amul...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Giuseppe Vallarelli <gvall...@redhat.com>
Gerrit-Reviewer: Mark Wu <wu...@linux.vnet.ibm.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
