Michal Skrivanek has posted comments on this change.
Change subject: Introduce a maximum time limit a migration may take
......................................................................
Patch Set 1:
(3 comments)
I think we need more feedback to the questions I posted...
....................................................
File lib/vdsm/config.py.in
Line 54: 'Maximum time the destination waits since migration is
stalled. '
Line 55: 'Please note, that this is not overall migration timeout. '
Line 56: 'Source waits twice as long (to avoid races).'),
Line 57:
Line 58: ('migration_max_time', '21600',
I wonder what's the best value to use. 6h sounds too much, OTOH 5mins is too
little. I also wonder if we should take into account the bandwidth limit and
VM's mem size….
Line 59: 'The maximum time in seconds a migration may take before
the '
Line 60: 'migration will be aborted.'),
Line 61:
Line 62: ('migration_listener_timeout', '30',
....................................................
File vdsm/vm.py
Line 763: memTotal, memProcessed, memRemaining,
Line 764: fileTotal, fileProcessed, _) = self._vm._dom.jobInfo()
Line 765:
Line 766: abort = False
Line 767: if time.time() - startTime > migrationMaxTime:
this way we don't start counting at the very beginning. The creation on dst
side is excluded. I wonder if we should do it or not….
Line 768: self._vm.log.warn('The migration took %d seconds
which is '
Line 769: 'exceeding the configured maximum
time '
Line 770: 'for migrations of %d seconds. The '
Line 771: 'migration has been aborted.',
Line 767: if time.time() - startTime > migrationMaxTime:
Line 768: self._vm.log.warn('The migration took %d seconds
which is '
Line 769: 'exceeding the configured maximum
time '
Line 770: 'for migrations of %d seconds. The '
Line 771: 'migration has been aborted.',
it should not be a past tense as we yet have to try to cancel. If it succeeds
in the meantime we will end up with correctly migrated VM
Line 772: time.time() - startTime,
migrationMaxTime)
Line 773: abort = True
Line 774: elif (smallest_dataRemaining is None or
Line 775: smallest_dataRemaining > dataRemaining):
--
To view, visit http://gerrit.ovirt.org/21708
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd2f76b9334fcb7d2db24c081cccae15e8fd0b0c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Lee Yarwood <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
