Vered Volansky has posted comments on this change. Change subject: storage: get currImgDir correctly in fileSD.deleteImage() ......................................................................
Patch Set 4: -Code-Review Huntxu, did you verify against other-than-gluster Storage Domains? Do we know the removed logic isn't necessary for them? What's the reason for the logic change from the last patch, which seemed just fine logically? Also, why are you against moving getImagePath into FileStorageDomain? It is, after all, the only class using this function. -- To view, visit http://gerrit.ovirt.org/22359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ee6cb963a428f18b6e43f0585d461d0975c377a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhun...@gmail.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Hunt Xu <mhun...@gmail.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
