Hunt Xu has posted comments on this change. Change subject: storage: get currImgDir correctly in fileSD.deleteImage() ......................................................................
Patch Set 4: I've tried both nfs and glusterfs and nothing abnormal observed. The problem is caused by that domaindir's base path of glusterSD and other file-based SD are not the same. For glusterSD, it's sd.storage_repository/mnt/glusterSD/, for other file-based storage domains it's sd.storage_repository/mnt/. However, using the domaindir member should work for all the file-based storage domains. The change from the last patch set is because that I realized that findDomain() is already done when we use sdCache.produce() to get the domain before we actually called this deleteImage() function in hsm.py. So we don't need to find it again. I am not strongly against moving getImagePath() into the FileStorageDomain class. However, since it's a one-liner and it has no other users, I don't see any benefit and thus any necessarity to make it an individual funtion. -- To view, visit http://gerrit.ovirt.org/22359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ee6cb963a428f18b6e43f0585d461d0975c377a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu <mhun...@gmail.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Eduardo <ewars...@redhat.com> Gerrit-Reviewer: Hunt Xu <mhun...@gmail.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
