Francesco Romani has posted comments on this change. Change subject: Introduce a maximum time limit a migration may take ......................................................................
Patch Set 7: Code-Review+1 (1 comment) .................................................... File vdsm/vm.py Line 787: # Migration is stuck, abort Line 788: self._vm.log.warn( Line 789: 'Migration is stuck: Hasn\'t progressed in %s seconds. ' Line 790: 'Aborting.' % (time.time() - lastProgressTime)) Line 791: abort = True Just a nit. I find a bit more readable if all the conditions leading to an abort are physically close in the source code. What do you think about swapping the two elif-s above? Line 792: Line 793: if abort: Line 794: self._vm._dom.abortJob() Line 795: self.stop() -- To view, visit http://gerrit.ovirt.org/21708 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd2f76b9334fcb7d2db24c081cccae15e8fd0b0c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Lee Yarwood <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Tomáš Došek <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
