Dan Kenigsberg has posted comments on this change. Change subject: vdsm: allow hooks to pass down dictionaries in json format ......................................................................
Patch Set 9: (2 comments) http://gerrit.ovirt.org/#/c/20330/9/vdsm/configNetwork.py File vdsm/configNetwork.py: Line 525: Line 526: Line 527: def _buildSetupHookDict(req_networks, req_bondings, req_options): Line 528: Line 529: hook_dict = {'request': {'networks': dict(req_networks), ok, ok, let this extra level of dictionary be my concession to the idea of passing something *but* 'request'. Line 530: 'bondings': dict(req_bondings), Line 531: 'options': dict(req_options)}} Line 532: Line 533: return hook_dict http://gerrit.ovirt.org/#/c/20330/9/vdsm/vdsmd.8.in File vdsm/vdsmd.8.in: Line 82: which holds a pointer to a file with the network parameters that vdsm is Line 83: setting up ( Line 84: .B request Line 85: ) Line 86: , the request may modified by the before_network_setup hook as thus affect may --> may be Line 87: the operation ultimately taken place by Vdsm.. Line 88: Line 89: The JSON format of this file has one section: request, this section Line 90: contains networks, bondings and options, those parameters are specified -- To view, visit http://gerrit.ovirt.org/20330 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie07c511e9740fd19a1c27baf87e91f9a427d0dcd Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Miguel Angel Ajo Pelayo <majop...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Assaf Muller <amul...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Miguel Angel Ajo Pelayo <majop...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
