Greg Padgett has posted comments on this change. Change subject: API: setHaMaintenanceMode command ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/23264/3/client/vdsClient.py File client/vdsClient.py: Line 1445: return 0, '' Line 1446: Line 1447: def do_setHaMaintenanceMode(self, args): Line 1448: mode = args[0] Line 1449: enabled = utils.tobool(args[1]) > Hi, Thanks for the feedback! It's not as clear/succinct, but args[1] is converted to a bool and stored in 'enabled', is that what you mean or am I misunderstanding? Line 1450: stats = self.s.setHaMaintenanceMode(mode, enabled) Line 1451: if stats['status']['code']: Line 1452: return stats['status']['code'], stats['status']['message'] Line 1453: return 0, '' -- To view, visit http://gerrit.ovirt.org/23264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic08c5edb0e9b8cc11eb70ef6a66301335c42aad3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
