Greg Padgett has posted comments on this change. Change subject: API: setHaMaintenanceMode command ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/23264/3/vdsm/API.py File vdsm/API.py: Line 1492: Sets Hosted Engine HA maintenance mode ('global' or 'local') to Line 1493: enabled (True) or disabled (False). Line 1494: """ Line 1495: if not haClient: Line 1496: return errCode['unavail'] > What happens in hosts with no ha agent? In that case the call won't be used. The engine uses the 'configured' key to determine whether to make the call, and in http://gerrit.ovirt.org/23263 this is True iff hosted engine is set up. Line 1497: Line 1498: self.log.info("Setting Hosted Engine HA {0} maintenance to {1}" Line 1499: .format(mode.lower(), enabled)) Line 1500: if mode.lower() == 'global': -- To view, visit http://gerrit.ovirt.org/23264 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic08c5edb0e9b8cc11eb70ef6a66301335c42aad3 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Greg Padgett <gpadg...@redhat.com> Gerrit-Reviewer: Oved Ourfali <oourf...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
