Antoni Segura Puimedon has posted comments on this change.

Change subject: xmlrpc: Support HTTP 1.1
......................................................................


Patch Set 2:

(1 comment)

Only a first read. Have to check the Python/Lib code

http://gerrit.ovirt.org/#/c/24294/2/lib/vdsm/utils.py
File lib/vdsm/utils.py:

Line 161:     # Additionally, add "Content-Length: 0" header on internal 
errors, when we
Line 162:     # don't send any content. This is required by HTTP 1.1, otherwise 
the
Line 163:     # client does not have any clue that the response was finished.
Line 164:     #
Line 165:     # These changes were taken from Python.7 version of this class. 
If we are
s/Python.7/Python2.7/
Line 166:     # running on Python 2.7, these changes are not needed, hence we 
override
Line 167:     # the methods only on Python 2.6.
Line 168: 
Line 169:     if sys.version_info[:2] == (2, 6):


-- 
To view, visit http://gerrit.ovirt.org/24294
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Nir Soffer <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to