Dan Kenigsberg has posted comments on this change. Change subject: xmlrpc: Support HTTP 1.1 ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/24294/2//COMMIT_MSG Commit Message: Line 16: methods are used only on Python 2.6. Python 2.7 already include these Line 17: changes. Then the protocol_version is set to HTTP/1.1, enabling Line 18: automatic keep-alive. Line 19: Line 20: We can see in the logs that only few threads are created now for service Kudos for this initiative, Nir. I have a vague memory of threading problems lurking somewhere. One certain thing was a need to use daemon=True for the now long-living ThreadingMixIn therads. Line 21: XMLRPC requests, and most requests are handled by the same thread. Line 22: Hopefully the code is not assuming that each request is performed in Line 23: different thread. Line 24: -- To view, visit http://gerrit.ovirt.org/24294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie033d5c53c81c8db99d5c26697a1727be030e0b4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
