Federico Simoncelli has uploaded a new change for review. Change subject: spbackends: do not set spmRole on forceFreeSpm ......................................................................
spbackends: do not set spmRole on forceFreeSpm Setting the spmRole to SPM_FREE on forceFreeSpm is harmful. In fact the release of the spm role (SPM_ACQUIRED) should go through the stopSpm procedure where the master filesystem is unmounted, etc. Change-Id: I2bd9a0d9749e49a97a31c535c92dd242eb8f74ec Signed-off-by: Federico Simoncelli <fsimo...@redhat.com> --- M vdsm/storage/spbackends.py 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/18/27318/1 diff --git a/vdsm/storage/spbackends.py b/vdsm/storage/spbackends.py index 86714a3..dddb749 100644 --- a/vdsm/storage/spbackends.py +++ b/vdsm/storage/spbackends.py @@ -327,7 +327,6 @@ # DO NOT USE, STUPID, HERE ONLY FOR BC # TODO: SCSI Fence the 'lastOwner' self.setSpmStatus(LVER_INVALID, SPM_ID_FREE, __securityOverride=True) - self.pool.spmRole = SPM_FREE @classmethod def _getPoolMD(cls, domain): -- To view, visit http://gerrit.ovirt.org/27318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2bd9a0d9749e49a97a31c535c92dd242eb8f74ec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches