Alon Bar-Lev has posted comments on this change. Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade ......................................................................
Patch Set 1: (4 comments) http://gerrit.ovirt.org/#/c/28244/1/vdsm_reg/vdsm-upgrade File vdsm_reg/vdsm-upgrade: Line 47: Line 48: rc, out, err = vdsm_service.status() Line 49: if rc == 0: Line 50: rc, out, err = vdsm_service.stop() Line 51: if rc != 0: this should go to new upgrade tool hook, so upgrading directly with tool with support vdsm properly. Line 52: msg = "<BSTRAP component='RHEL_INSTALL' status='FAIL'" \ Line 53: " message='Cannot stop vdsm daemon before we" \ Line 54: " start the upgrade, please verify!'/>" Line 55: else: Line 65: if rc == 0: Line 66: cmd = [ Line 67: 'ovirt-node-upgrade', Line 68: '--iso', Line 69: '/data/updates/ovirt-node-iso-image.iso', please do not mix --xxx yyy and --xxx=yyy Line 70: '--reboot=1' Line 71: ] Line 72: Line 73: rc, out, err = utils.execCmd(cmd, sudo=True, raw=True) Line 67: 'ovirt-node-upgrade', Line 68: '--iso', Line 69: '/data/updates/ovirt-node-iso-image.iso', Line 70: '--reboot=1' Line 71: ] I was kinda hopped to get the stdout as messages... is it possible? not very important. Line 72: Line 73: rc, out, err = utils.execCmd(cmd, sudo=True, raw=True) Line 74: if rc != 0: Line 75: msg = "<BSTRAP component='RHEV_INSTALL' status='FAIL'/>" Line 80: print(msg) Line 81: return rc Line 82: Line 83: if __name__ == "__main__": Line 84: main() we still need rc at exit for success / failure. -- To view, visit http://gerrit.ovirt.org/28244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b997d70a440545497246d1a19d9671b054a56a5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Joey Boggs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
