Dan Kenigsberg has posted comments on this change. Change subject: vdsm-upgrade: adds wrapper to ovirt-node-upgrade ......................................................................
Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/28244/1/vdsm_reg/vdsm-upgrade File vdsm_reg/vdsm-upgrade: Line 15: Line 16: Line 17: class VdsmService(object): Line 18: def __init__(self): Line 19: self.cmd = ['vdsm-tool', '', 'vdsmd'] Keeping this list as a data member is awkward. This whole class should not have any state; if you want to keep it, keep it as a name space with classmethods - you don't really need to instantiate it. Line 20: Line 21: def start(self): Line 22: self.cmd[1] = "service-start" Line 23: return utils.execCmd(self.cmd, sudo=True, raw=True) Line 27: return utils.execCmd(self.cmd, sudo=True, raw=True) Line 28: Line 29: def status(self): Line 30: self.cmd[1] = "service-status" Line 31: return utils.execCmd(self.cmd, sudo=True, raw=True) Status does not need sudo Line 32: Line 33: Line 34: def main(): Line 35: _log_file = '/var/log/vdsm-reg/vds_bootstrap_upgrade.' + \ -- To view, visit http://gerrit.ovirt.org/28244 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7b997d70a440545497246d1a19d9671b054a56a5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]> Gerrit-Reviewer: Joey Boggs <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
