Francesco Romani has posted comments on this change. Change subject: Collect current QoS settings for IO devices and report through RunningVmStats ......................................................................
Patch Set 2: Code-Review+1 (1 comment) Looks OK. On a sidenote, I'm a bit worried by RunningVmStats getting bigger and bigger, but this has little to do with this patch, and there is even less this patch can do to ameliorate this. http://gerrit.ovirt.org/#/c/28712/2/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 333: return infos Line 334: Line 335: def _sampleIoTune(self): Line 336: info = [] Line 337: for device in self._vm._devices: Unless I'm missing something, you can narrow down the search by using for device in self._vm._devices[DISK_DEVICES]: Line 338: if not isVdsmImage(device): Line 339: continue Line 340: Line 341: try: -- To view, visit http://gerrit.ovirt.org/28712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fab132b60ce6ae2285115034f3d1ffcdca9e9d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
