Francesco Romani has posted comments on this change. Change subject: Collect current QoS settings for IO devices and report through RunningVmStats ......................................................................
Patch Set 6: (1 comment) Not happy about parsing XML each 15 seconds, but I don't think there is another way around, right? http://gerrit.ovirt.org/#/c/28712/6/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 341: self._log.exception("Error while collecting ioTune for %s", Line 342: self._vm.name) Line 343: return None Line 344: Line 345: devxml = _domParseStr(lastXMLDesc).childNodes[0] \ Well, even if we are in the sampling thread, to parse the full domain XML *each* time is bad. I assume there isn't any other way around, but still I'm surprised this is the blessed way. Line 346: .getElementsByTagName('devices')[0] Line 347: Line 348: diskxml = devxml.getElementsByTagName('disk') Line 349: -- To view, visit http://gerrit.ovirt.org/28712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie4fab132b60ce6ae2285115034f3d1ffcdca9e9d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
