Yoav Kleinberger has posted comments on this change. Change subject: clarify that scsiKey parameter is not passed on ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/28560/1/vdsm/API.py File vdsm/API.py: Line 983: self._UUID = UUID Line 984: Line 985: def connect(self, hostID, scsiKey, masterSdUUID, masterVersion, Line 986: domainsMap=None): Line 987: # scsiKey is deprecated. it is retained here so as not to break the API > The comment is good but it repeats 3 times, which is little annoying. Since Done Line 988: return self._irs.connectStoragePool( Line 989: self._UUID, hostID, masterSdUUID, masterVersion, domainsMap) Line 990: Line 991: def connectStorageServer(self, domainType, connectionParams): -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
