Dan Kenigsberg has submitted this change and it was merged. Change subject: clarify that scsiKey parameter is not passed on ......................................................................
clarify that scsiKey parameter is not passed on In this patch I add documentation to make plain that the scsiKey parameter is a legacy from older code. In the code itself, I changed the parameter name so that this is clear to the next developer that comes along, and hopefully will save him/her a wild goose chase. Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Signed-off-by: Yoav Kleinberger <yklei...@redhat.com> Reviewed-on: http://gerrit.ovirt.org/28560 Reviewed-by: Nir Soffer <nsof...@redhat.com> Reviewed-by: Dan Kenigsberg <dan...@redhat.com> --- M vdsm/API.py M vdsm/rpc/vdsmapi-schema.json 2 files changed, 6 insertions(+), 7 deletions(-) Approvals: Nir Soffer: Looks good to me, but someone else must approve Yoav Kleinberger: Verified Dan Kenigsberg: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/28560 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5edc98058f2332deb6ee040879b4f7c635aefbc2 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: Yoav Kleinberger <yklei...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
