mooli tayer has posted comments on this change. Change subject: vdsm-tool: Add logging configuration. ......................................................................
Patch Set 9: (1 comment) small nit. looks good. http://gerrit.ovirt.org/#/c/27481/9/vdsm-tool/vdsm-tool File vdsm-tool/vdsm-tool: Line 169: load_modules() Line 170: Line 171: try: Line 172: opts, args = getopt.getopt(sys.argv[1:], "hl:va", Line 173: ["help", "logfile=", "append", could you make short and long options have same order? Line 174: "verbose", "vverbose", "vvverbose"]) Line 175: except getopt.GetoptError: Line 176: usage_and_exit(1) Line 177: -- To view, visit http://gerrit.ovirt.org/27481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia495743f6e869f65843404e4d4c25c146ff14b43 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
