Yaniv Bronhaim has posted comments on this change. Change subject: vdsm-tool: Add logging configuration. ......................................................................
Patch Set 10: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/27481/10/vdsm-tool/vdsm-tool File vdsm-tool/vdsm-tool: Line 135: "\t\tInclude information (and above) messages in log.", Line 136: " -vvv, --vvverbose", Line 137: "\t\tInclude debug (and above) messages in log.", Line 138: " -a, --append", Line 139: "\t\tAppend to logfile instead of truncating it", > I thought verbose will mean to print the output also to stdout. for logging oh, missed the conversion about it: http://gerrit.ovirt.org/#/c/27481/8/vdsm-tool/vdsm-tool,cm can't ignore toni's tradition :) its fine by me. just wondered why not using level Line 140: "(if logging to a file)."])) Line 141: Line 142: for mod_name, mod_desc in tool_modules: Line 143: _usage_module(mod_name, mod_desc) -- To view, visit http://gerrit.ovirt.org/27481 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia495743f6e869f65843404e4d4c25c146ff14b43 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Dima Kuznetsov <dkuzn...@redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsl...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
