Dan Kenigsberg has posted comments on this change. Change subject: vdsm: Removal of management_ip info in getCaps ......................................................................
Patch Set 1: Code-Review-1 (2 comments) http://gerrit.ovirt.org/#/c/28993/1//COMMIT_MSG Commit Message: Line 6: Line 7: vdsm: Removal of management_ip info in getCaps Line 8: Line 9: 'management_ip' information do not provide any value Line 10: so it was removed from the result of getCapabilities. Please rephrase: 'management_ip' does not provide any value, and was never used by Engine. Therefore, it is now removed from the result of getCapabilities. Line 11: Line 12: Line 13: Change-Id: I5a5851a55995e7d1bb617cc958f8bfee7dfb994a http://gerrit.ovirt.org/#/c/28993/1/vdsm/rpc/BindingXMLRPC.py File vdsm/rpc/BindingXMLRPC.py: Line 43: class BindingXMLRPC(object): Line 44: def __init__(self, cif, log, port, default_bridge): Line 45: self.cif = cif Line 46: self.log = log Line 47: self.serverPort = port ahhem, port and default_bridge are not used, too. I did not expect this patch to touch internal interfaces, but you may drop two more args. (here or in another patch) Line 48: self.defaultBridge = default_bridge Line 49: Line 50: self._enabled = False Line 51: self.server = self._createXMLRPCServer() -- To view, visit http://gerrit.ovirt.org/28993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a5851a55995e7d1bb617cc958f8bfee7dfb994a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
