Nir Soffer has posted comments on this change. Change subject: vdsm: Removal of management_ip info in getCaps ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/28993/1/vdsm/rpc/BindingXMLRPC.py File vdsm/rpc/BindingXMLRPC.py: Line 43: class BindingXMLRPC(object): Line 44: def __init__(self, cif, log, port, default_bridge): Line 45: self.cif = cif Line 46: self.log = log Line 47: self.serverPort = port > I agree that we can remove default_bridge but we need to have serverPort. I migration.py can get it from the config, there is no reason that migration will poke into xmlrpc binding internals. But this is not related to this patch, lests keep patches small and focused. Removing unused parameter is easy and safe change that can be merged quickly. Line 48: self.defaultBridge = default_bridge Line 49: Line 50: self._enabled = False Line 51: self.server = self._createXMLRPCServer() -- To view, visit http://gerrit.ovirt.org/28993 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a5851a55995e7d1bb617cc958f8bfee7dfb994a Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegu...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
