Alon Bar-Lev has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/31561/7/vdsm.spec.in File vdsm.spec.in: Line 720: # When starting vdsm, init script will peform reconfigure automatically Line 721: if [ "$1" -ge 1 ]; then Line 722: if [ "$(rpm -q vdsm 2> /dev/null | sed 's/^vdsm-4\.10\..*/OK/')" = "OK" ]; Line 723: then Line 724: touch %{_localstatedir}/lib/%{vdsm_name}/requires_configure > We can avoid quotes here since we assume lack of spaces in %{_localstatedir not sure why assuming anything and have exceptional statements for multiple cases, but... Line 725: fi Line 726: fi Line 727: Line 728: %post -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
