mooli tayer has posted comments on this change. Change subject: Signs vdsm upgraded version for special treatment if required ......................................................................
Patch Set 12: (1 comment) http://gerrit.ovirt.org/#/c/31561/12/init/vdsmd_init_common.sh.in File init/vdsmd_init_common.sh.in: Line 204: local ret=0 Line 205: if grep -q '^vdsm-4\.10\.' "${upgraded_ver_file}"; then Line 206: # We need to treat the upgrade from 4.10.x specifically Line 207: # by running manual configure command Line 208: "$VDSM_TOOL" configure --force > mooli: doing that will lead to libvirt service restart. but doing that in s My concern is this: vdsm-tool at init might cause: $ service vdsmd start long wait... failed [service actually starts normally] did you see this or is it just the long wait? If it's just the long wait I will not harass you anymore. also take heed I see some jenkins failures. Line 209: ret=$? Line 210: fi Line 211: [ "${ret}" -eq 0 ] && rm -f "${upgraded_ver_file}" Line 212: fi -- To view, visit http://gerrit.ovirt.org/31561 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I412dc9992675acbb9d03dfa645468789cfb6e65e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
