Dan Kenigsberg has posted comments on this change. Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet ......................................................................
Patch Set 10: Code-Review-1 (3 comments) http://gerrit.ovirt.org/#/c/31529/10/lib/vdsm/constants.py.in File lib/vdsm/constants.py.in: Line 147: EXT_SETSID = '@SETSID_PATH@' Line 148: EXT_SH = '/bin/sh' # The shell path is invariable Line 149: EXT_SU = '@SU_PATH@' Line 150: EXT_SUDO = '@SUDO_PATH@' Line 151: EXT_SYSCTL = '@SYSCTL_PATH@' We try to make this module thinner, by using CommandPath in runtime. Line 152: Line 153: EXT_TAR = '@TAR_PATH@' Line 154: EXT_TEE = '@TEE_PATH@' Line 155: EXT_TUNE2FS = '@TUNE2FS_PATH@' http://gerrit.ovirt.org/#/c/31529/10/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 1137: Line 1138: def sysctlCmd(key, value): Line 1139: option = '%s=%s' % (key, value) Line 1140: cmd = [constants.EXT_SYSCTL, '-w', option] Line 1141: rc, out, err = execCmd(cmd, sudo=True) Please avoid using sudo - use define a new supervdsm entry point, instead. Line 1142: if rc != 0: http://gerrit.ovirt.org/#/c/31529/10/vdsm/storage/iscsi.py File vdsm/storage/iscsi.py: Line 163: key, value, hideValue=True) Line 164: Line 165: if iface.netIfacename: Line 166: sysctlOpt = 'net.ipv4.conf.%s.rp_filter' % iface.netIfacename Line 167: sysctlCmd(sysctlOpt, '2') The toughest thing in this approach is to properly handle removal of iscsi sessions. When no session uses the network iface, we should revert its rp_filter to strict. Line 168: Line 169: iscsiadm.node_login(iface.name, portalStr, target.iqn) Line 170: Line 171: iscsiadm.node_update(iface.name, portalStr, target.iqn, -- To view, visit http://gerrit.ovirt.org/31529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
