Antoni Segura Puimedon has posted comments on this change. Change subject: Sysctl to allow iSCSI multipath with multiple NICs in the same subnet ......................................................................
Patch Set 14: Code-Review-1 (1 comment) http://gerrit.ovirt.org/#/c/31529/14/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 357: @logDecorator Line 358: def sysctlCmd(self, key, value): Line 359: option = '='.join([key, value]) Line 360: cmd = [_SYSCTL_BINARY.cmd, '-w', option] Line 361: rc, out, err = utils.execCmd(cmd) Instead of starting a process like sysctl, I think it'd be best to use the newer and preferred interface of file access to /proc/sys/ for example you have: /proc/sys/net/ipv4/conf/default/arp_ignore Line 362: if rc: Line 363: self.log.error("Sysctl -w command failed rc=%s, " Line 364: "out=\"%s\", err=\"%s\"", rc, out, err) Line 365: raise OSError(errno.EINVAL, "Could not set sysctl option " -- To view, visit http://gerrit.ovirt.org/31529 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf93d49317c76aece764e53e58e0ff28868f16b0 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amador Pahim <[email protected]> Gerrit-Reviewer: Amador Pahim <[email protected]> Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
