Francesco Romani has posted comments on this change. Change subject: virt: sampling: consolidate disk statistics ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/29953/4//COMMIT_MSG Commit Message: Line 16: and cheaper to read all the needed information in one go, Line 17: saving one libvirt call without losing any information. Line 18: Line 19: If the configuration is different, the old behaviour is Line 20: preserved for the sake of backward compatibility. > Do we need this backward compatibility? I think this configuration is for u I agree with you, because the backward compatibility makes the code uglier in every way I can conceive. But we exposed these settings to the user (and long ago), so we are bound to keep them for all the 3.x.y cycle, I believe. Dan? Line 21: Line 22: Change-Id: I0dabd079f81270c7099c74469a18f8b23c97cc8c -- To view, visit http://gerrit.ovirt.org/29953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabd079f81270c7099c74469a18f8b23c97cc8c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches