Nir Soffer has posted comments on this change. Change subject: virt: sampling: consolidate disk statistics ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/29953/5/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 306: Line 307: diskSamples = {} Line 308: for vmDrive in self._vm.getDiskDevices(): Line 309: diskSamples[vmDrive.name] = self._vm._dom.blockStatsFlags( Line 310: vmDrive.name, flags=libvirt.VIR_TYPED_PARAM_STRING_OKAY) > This is the call getDiskLatency uses until this change, and gives us a supe Ok - it would be nice to document this cryptic flag (in another patch if you like) Line 311: Line 312: return diskSamples Line 313: Line 314: def _sampleDiskLatency(self): -- To view, visit http://gerrit.ovirt.org/29953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabd079f81270c7099c74469a18f8b23c97cc8c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
