Francesco Romani has posted comments on this change. Change subject: virt: sampling: consolidate disk statistics ......................................................................
Patch Set 7: (1 comment) http://gerrit.ovirt.org/#/c/29953/7/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 299: # depending on is ok with that. Quoting libvirt header: Line 300: # """Older servers lacked the ability to handle string typed Line 301: # parameters.[...] This flag is automatically set when needed, Line 302: # [...] however, manually setting the flag can be used to Line 303: # reject servers that cannot return typed strings [...]""" > Hmm, according to the current patch, the line with this cryptic flag alread Sorry for the rebase noise, I'll rebase less often (here and of course in any other future patch). The cryptic flag was always used since sampleDiskLatency existed; in this patch I'm just moving from blockStats to blockStatsFlags in sampleDisk, hence the reason why it popped out here. Will move the explanation in a new separate doc-only patch. Line 304: return diskSamples Line 305: Line 306: def _sampleNet(self): Line 307: netSamples = {} -- To view, visit http://gerrit.ovirt.org/29953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dabd079f81270c7099c74469a18f8b23c97cc8c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
